TabCtrl_SetImageList macro error in CommCtrl.bi

[PaulSquires]

The macro in 'commctrl.bi' for TabCtrl_SetImageList is incorrect. It will cause a compile time error.

Code: Select all

' Incorrect
#define TabCtrl_SetImageList(w,h) cast((HIMAGELIST,SNDMSG(w,TCM_SETIMAGELIST,0,cint(cUINT(h))))

' Correct
#define TabCtrl_SetImageList(w,h) cast(HIMAGELIST,SNDMSG(w,TCM_SETIMAGELIST,0,CInt(h)))

[PaulSquires]

Likewise, there is an error in the TabCtrl_AdjustRect macro. It is missing a trailing closing parenthesis ")".

Code: Select all

'Incorrect:
#define TabCtrl_AdjustRect(w,b,p) cint(SNDMSG(w,TCM_ADJUSTRECT,b,cint(cast(LPRECT,p)))

'Correct:
#define TabCtrl_AdjustRect(w,b,p) CInt(SNDMSG(w,TCM_ADJUSTRECT,b,CInt(cast(LPRECT,p))))

[dkl]

I applied the fixes at freebasic-headers, thanks.

[counting_pine]

The macro in 'commctrl.bi' for TabCtrl_SetImageList is incorrect. It will cause a compile time error.

Code: Select all

' Incorrect
#define TabCtrl_SetImageList(w,h) cast((HIMAGELIST,SNDMSG(w,TCM_SETIMAGELIST,0,cint(cUINT(h))))

' Correct
#define TabCtrl_SetImageList(w,h) cast(HIMAGELIST,SNDMSG(w,TCM_SETIMAGELIST,0,CInt(h)))

For what it's worth, from http://source.winehq.org/source/include ... rl.h#L4047 it looks like (at least) one extra cast is warranted on the h parameter.
Therefore I think a better change would just be to remove the (obviously) erroneous extra '(' near the start ('cast((HIMAGELIST,...')